Add Empty Query Returning & Change ThemeSelector Keyword with ActionKeyword for Sys Plugin #3833

WayneFerdon · 2025-07-15T13:31:41Z

Support returning all usable commands while query is empty.
Should the Plugin.Sys returns all usable commands while the query is empty? #2040
ChangeQuery by ThemeSelector Action with ActionKeyword at the front as well

…query is empty; ChangeQuery by ThemeSelector Action with ActionKeyword at the front as well

coderabbitai · 2025-07-15T13:33:48Z

📝 Walkthrough

Walkthrough

The Commands method in Main.cs was updated to accept a Query parameter. The command filtering logic now distinguishes between empty and non-empty queries, returning all commands unfiltered when the query is empty. The theme selector command's query string construction was also modified for greater flexibility.

Changes

File(s)	Change Summary
Plugins/Flow.Launcher.Plugin.Sys/Main.cs	Updated `Commands` method signature to accept `Query`; improved empty query handling and command filtering; adjusted theme selector query string construction.

Suggested labels

enhancement

Suggested reviewers

jjw24

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a34b8f2 and 539a852.

📒 Files selected for processing (1)

Plugins/Flow.Launcher.Plugin.Sys/Main.cs (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

Plugins/Flow.Launcher.Plugin.Sys/Main.cs

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

Plugins/Flow.Launcher.Plugin.Sys/Main.cs (1)
75-75: Simplify redundant string checks.

The condition uses both IsNullOrEmpty and IsNullOrWhiteSpace, but IsNullOrWhiteSpace already covers null, empty, and whitespace-only strings.
-var isEmptyQuery = string.IsNullOrEmpty(query.Search) || string.IsNullOrWhiteSpace(query.Search);
+var isEmptyQuery = string.IsNullOrWhiteSpace(query.Search);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa6301b and a34b8f2.

📒 Files selected for processing (1)

Plugins/Flow.Launcher.Plugin.Sys/Main.cs (3 hunks)

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: Yusyuriv
PR: Flow-Launcher/Flow.Launcher#3118
File: Flow.Launcher/ViewModel/MainViewModel.cs:1404-1413
Timestamp: 2024-12-08T21:12:12.060Z
Learning: In the `MainViewModel` class, the `_lastQuery` field is initialized in the constructor and is never null.

🔇 Additional comments (3)

Plugins/Flow.Launcher.Plugin.Sys/Main.cs (3)

73-73: LGTM - Method call updated correctly.

The method call has been properly updated to pass the query parameter to match the new method signature.

81-85: LGTM - Empty query handling implemented correctly.

The implementation correctly returns all commands unfiltered when the query is empty, which aligns with the PR objective of showing all available commands without typing any query text.

197-197: LGTM - Method signature updated appropriately.

The method signature correctly accepts a Query parameter, enabling access to query information needed for the theme selector functionality.

Plugins/Flow.Launcher.Plugin.Sys/Main.cs

github-actions · 2025-07-15T14:00:49Z

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors and Warnings	Count
❌ forbidden-pattern	13
⚠️ non-alpha-in-dictionary	2

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

binary file (or some other file you wouldn't want to check at all).

Please add a file path to the excludes.txt file matching the containing file.

File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).
well-formed pattern.

If you can write a pattern that would match it,
try adding it to the patterns.txt file.

Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

Note that patterns can't match multiline strings.

Jack251970

It looks good to me. Thanks for your contribution!

Add Empty Query Returning & Change ThemeSelector Keyword with ActionKeyword for Sys Plugin

[Plugin.Sys Enhancement] Support returning all usable commands while …

a34b8f2

…query is empty; ChangeQuery by ThemeSelector Action with ActionKeyword at the front as well

github-actions bot assigned WayneFerdon Jul 15, 2025

coderabbitai bot added the enhancement New feature or request label Jul 15, 2025

Merge branch 'dev' into dev

47089bd

This comment has been minimized.

Sign in to view

coderabbitai bot reviewed Jul 15, 2025

View reviewed changes

Plugins/Flow.Launcher.Plugin.Sys/Main.cs Outdated Show resolved Hide resolved

Jack251970 added 2 commits July 15, 2025 21:50

Simplify logic

aece803

Improve logic

539a852

Jack251970 changed the title ~~[Plugin.Sys Enhancement] Empty Query Returning & ThemeSelector Command ChangeQuery with ActionKeyword~~ Add Empty Query Returning & Change ThemeSelector Keyword with ActionKeyword for Sys Plugin Jul 15, 2025

Jack251970 approved these changes Jul 15, 2025

View reviewed changes

Jack251970 enabled auto-merge July 15, 2025 14:01

Jack251970 merged commit 3e1f962 into Flow-Launcher:dev Jul 15, 2025
4 checks passed

TBM13 pushed a commit to TBM13/Flow.Launcher that referenced this pull request Jul 16, 2025

Merge pull request Flow-Launcher#3833 from WayneFerdon/dev

0249b25

Add Empty Query Returning & Change ThemeSelector Keyword with ActionKeyword for Sys Plugin

Jack251970 added this to the 2.0.0 milestone Jul 17, 2025

jjw24 mentioned this pull request Aug 31, 2025

Release 2.0.0 | Plugin 5.0.0 #3904

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Add Empty Query Returning & Change ThemeSelector Keyword with ActionKeyword for Sys Plugin #3833

Add Empty Query Returning & Change ThemeSelector Keyword with ActionKeyword for Sys Plugin #3833

WayneFerdon commented Jul 15, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

coderabbitai bot commented Jul 15, 2025 •

edited

Loading

Walkthrough

Changes

Suggested labels

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

Jack251970 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Add Empty Query Returning & Change ThemeSelector Keyword with ActionKeyword for Sys Plugin #3833

Add Empty Query Returning & Change ThemeSelector Keyword with ActionKeyword for Sys Plugin #3833

Conversation

WayneFerdon commented Jul 15, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

coderabbitai bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested labels

Suggested reviewers

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jul 15, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Uh oh!

Jack251970 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Jul 15, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)